wgtmac commented on code in PR #418:
URL: https://github.com/apache/iceberg-cpp/pull/418#discussion_r2630934066
##########
src/iceberg/table.cc:
##########
@@ -21,16 +21,40 @@
#include "iceberg/catalog.h"
#include "iceberg/partition_spec.h"
+#include "iceberg/result.h"
#include "iceberg/schema.h"
#include "iceberg/sort_order.h"
#include "iceberg/table_metadata.h"
#include "iceberg/table_properties.h"
#include "iceberg/table_scan.h"
+#include "iceberg/transaction.h"
#include "iceberg/update/update_properties.h"
#include "iceberg/util/macros.h"
namespace iceberg {
+Result<std::shared_ptr<Table>> Table::Make(TableIdentifier identifier,
+ std::shared_ptr<TableMetadata>
metadata,
+ std::string metadata_location,
+ std::shared_ptr<FileIO> io,
+ std::shared_ptr<Catalog> catalog) {
+ if (metadata == nullptr) [[unlikely]] {
Review Comment:
How about a dedicated PR for this? I think there are other places using the
same pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
