aiborodin commented on code in PR #14878:
URL: https://github.com/apache/iceberg/pull/14878#discussion_r2633193441
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriter.java:
##########
@@ -145,6 +145,7 @@ public void write(DynamicRecordInternal element, Context
context)
return taskWriterFactory.create();
})
.write(element.rowData());
+ metrics.numRecordsOutCounter().inc();
Review Comment:
I wanted to use a standard Flink metric because things like Autoscaler might
rely on it to estimate throughput. It seems these metrics were specifically
made for V2 sinks to report the number of records sent to downstream systems,
from the javadoc of `Counter getNumRecordsSendCounter()`:
> The total number of records have been sent to the downstream system.
> <p>Note: this counter will count all records the SinkWriter sent. From
SinkWirter's
> * perspective, these records have been sent to the downstream system,
but the downstream system
> * may have issue to perform the persistence action within its scope.
...
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
