wgtmac commented on code in PR #417:
URL: https://github.com/apache/iceberg-cpp/pull/417#discussion_r2634452918
##########
src/iceberg/catalog/rest/rest_catalog.cc:
##########
@@ -81,6 +81,9 @@ RestCatalog::~RestCatalog() = default;
Result<std::shared_ptr<RestCatalog>> RestCatalog::Make(
const RestCatalogProperties& config, std::shared_ptr<FileIO> file_io) {
ICEBERG_ASSIGN_OR_RAISE(auto uri, config.Uri());
+ if (!file_io) {
+ return RestError("FileIO instance is required to create RestCatalog");
Review Comment:
```suggestion
return InvalidArgument("FileIO is required to create RestCatalog");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
