rymurr commented on a change in pull request #1587: URL: https://github.com/apache/iceberg/pull/1587#discussion_r521398634
########## File path: nessie/src/test/java/org/apache/iceberg/nessie/TestNessieTable.java ########## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.nessie; + + +import com.dremio.nessie.error.NessieConflictException; +import com.dremio.nessie.error.NessieNotFoundException; +import com.dremio.nessie.model.Branch; +import com.dremio.nessie.model.ContentsKey; +import com.dremio.nessie.model.IcebergTable; +import java.io.File; +import java.io.IOException; +import java.nio.file.Paths; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.stream.Collectors; +import org.apache.avro.generic.GenericData; +import org.apache.avro.generic.GenericRecordBuilder; +import org.apache.hadoop.fs.Path; +import org.apache.iceberg.DataFile; +import org.apache.iceberg.DataFiles; +import org.apache.iceberg.Files; +import org.apache.iceberg.HasTableOperations; +import org.apache.iceberg.ManifestFile; +import org.apache.iceberg.Schema; +import org.apache.iceberg.Table; +import org.apache.iceberg.TableMetadataParser; +import org.apache.iceberg.avro.Avro; +import org.apache.iceberg.avro.AvroSchemaUtil; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.exceptions.CommitFailedException; +import org.apache.iceberg.io.FileAppender; +import org.apache.iceberg.types.Types; +import org.junit.After; +import org.junit.Assert; +import org.junit.Before; +import org.junit.Test; + +import static org.apache.iceberg.TableMetadataParser.getFileExtension; +import static org.apache.iceberg.types.Types.NestedField.optional; +import static org.apache.iceberg.types.Types.NestedField.required; + + +public class TestNessieTable extends BaseTestIceberg { + + private static final String BRANCH = "iceberg-table-test"; + + private static final String DB_NAME = "db"; + private static final String TABLE_NAME = "tbl"; + private static final TableIdentifier TABLE_IDENTIFIER = TableIdentifier.of(DB_NAME, TABLE_NAME); + private static final ContentsKey KEY = ContentsKey.of(DB_NAME, TABLE_NAME); + private static final Schema schema = new Schema(Types.StructType.of( + required(1, "id", Types.LongType.get())).fields()); + private static final Schema altered = new Schema(Types.StructType.of( + required(1, "id", Types.LongType.get()), + optional(2, "data", Types.LongType.get())).fields()); + + private Path tableLocation; + + public TestNessieTable() { + super(BRANCH); + } + + @Before + public void beforeEach() throws NessieConflictException, NessieNotFoundException { + super.beforeEach(); + this.tableLocation = new Path(catalog.createTable(TABLE_IDENTIFIER, schema).location()); + } + + @After + public void afterEach() throws Exception { + // drop the table data + if (tableLocation != null) { + tableLocation.getFileSystem(hadoopConfig).delete(tableLocation, true); + catalog.refresh(); + catalog.dropTable(TABLE_IDENTIFIER, false); + } + + super.afterEach(); + } + + private com.dremio.nessie.model.IcebergTable getTable(ContentsKey key) throws NessieNotFoundException { + return client.getContentsApi() + .getContents(key, BRANCH) + .unwrap(IcebergTable.class).get(); + } + + @Test + public void testCreate() throws NessieNotFoundException { + // Table should be created in iceberg + // Table should be renamed in iceberg + String tableName = TABLE_IDENTIFIER.name(); + Table icebergTable = catalog.loadTable(TABLE_IDENTIFIER); + // add a column + icebergTable.updateSchema().addColumn("mother", Types.LongType.get()).commit(); + IcebergTable table = getTable(KEY); + // check parameters are in expected state + Assert.assertEquals(getTableLocation(tableName), + (tempDir.toURI().toString() + DB_NAME + "/" + + tableName).replace("//", + "/")); + + // Only 1 snapshotFile Should exist and no manifests should exist + Assert.assertEquals(2, metadataVersionFiles(tableName).size()); + Assert.assertEquals(0, manifestFiles(tableName).size()); + } + + + @SuppressWarnings("VariableDeclarationUsageDistance") + @Test + public void testRename() { + String renamedTableName = "rename_table_name"; + TableIdentifier renameTableIdentifier = TableIdentifier.of(TABLE_IDENTIFIER.namespace(), + renamedTableName); + + Table original = catalog.loadTable(TABLE_IDENTIFIER); + + catalog.renameTable(TABLE_IDENTIFIER, renameTableIdentifier); + Assert.assertFalse(catalog.tableExists(TABLE_IDENTIFIER)); + Assert.assertTrue(catalog.tableExists(renameTableIdentifier)); + + Table renamed = catalog.loadTable(renameTableIdentifier); + + Assert.assertEquals(original.schema().asStruct(), renamed.schema().asStruct()); + Assert.assertEquals(original.spec(), renamed.spec()); + Assert.assertEquals(original.location(), renamed.location()); + Assert.assertEquals(original.currentSnapshot(), renamed.currentSnapshot()); + + Assert.assertTrue(catalog.dropTable(renameTableIdentifier)); + } + + @Test + public void testDrop() { + Assert.assertTrue(catalog.tableExists(TABLE_IDENTIFIER)); + Assert.assertTrue(catalog.dropTable(TABLE_IDENTIFIER)); + Assert.assertFalse(catalog.tableExists(TABLE_IDENTIFIER)); + } + + @Test + public void testDropWithoutPurgeLeavesTableData() throws IOException { + Table table = catalog.loadTable(TABLE_IDENTIFIER); + + GenericRecordBuilder recordBuilder = + new GenericRecordBuilder(AvroSchemaUtil.convert(schema, "test")); + List<GenericData.Record> records = new ArrayList<>(); + records.add(recordBuilder.set("id", 1L).build()); + records.add(recordBuilder.set("id", 2L).build()); + records.add(recordBuilder.set("id", 3L).build()); + + String fileLocation = table.location().replace("file:", "") + "/data/file.avro"; + try (FileAppender<GenericData.Record> writer = Avro.write(Files.localOutput(fileLocation)) + .schema(schema) + .named("test") + .build()) { + for (GenericData.Record rec : records) { + writer.add(rec); + } + } + + DataFile file = DataFiles.builder(table.spec()) + .withRecordCount(3) + .withPath(fileLocation) + .withFileSizeInBytes(Files.localInput(fileLocation).getLength()) + .build(); + + table.newAppend().appendFile(file).commit(); + + String manifestListLocation = + table.currentSnapshot().manifestListLocation().replace("file:", ""); + + Assert.assertTrue(catalog.dropTable(TABLE_IDENTIFIER, false)); + Assert.assertFalse(catalog.tableExists(TABLE_IDENTIFIER)); + + Assert.assertTrue(new File(fileLocation).exists()); + Assert.assertTrue(new File(manifestListLocation).exists()); + } + + + @SuppressWarnings("VariableDeclarationUsageDistance") + @Test + public void testDropTable() throws IOException { + Table table = catalog.loadTable(TABLE_IDENTIFIER); + + GenericRecordBuilder recordBuilder = + new GenericRecordBuilder(AvroSchemaUtil.convert(schema, "test")); + List<GenericData.Record> records = new ArrayList<>(); + records.add(recordBuilder.set("id", 1L).build()); + records.add(recordBuilder.set("id", 2L).build()); + records.add(recordBuilder.set("id", 3L).build()); + + String location1 = table.location().replace("file:", "") + "/data/file1.avro"; + try (FileAppender<GenericData.Record> writer = Avro.write(Files.localOutput(location1)) + .schema(schema) + .named("test") + .build()) { + for (GenericData.Record rec : records) { + writer.add(rec); + } + } + + String location2 = table.location().replace("file:", "") + "/data/file2.avro"; + try (FileAppender<GenericData.Record> writer = Avro.write(Files.localOutput(location2)) + .schema(schema) + .named("test") + .build()) { Review comment: :+1: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
