nastra commented on code in PR #14882:
URL: https://github.com/apache/iceberg/pull/14882#discussion_r2635187066
##########
core/src/main/java/org/apache/iceberg/SingleValueParser.java:
##########
@@ -414,4 +387,68 @@ public static void toJson(Type type, Object defaultValue,
JsonGenerator generato
throw new UnsupportedOperationException(String.format("Type: %s is not
supported", type));
}
}
+
+ private static Object parseDateValue(Type type, JsonNode value) {
+ if (value.isTextual()) {
+ return DateTimeUtil.isoDateToDays(value.textValue());
+ } else if (value.isIntegralNumber() && value.canConvertToInt()) {
Review Comment:
I think these changes are probably not required to fix the underlying issue,
so we might want to separate them out and test them individually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
