RussellSpitzer commented on issue #14790:
URL: https://github.com/apache/iceberg/issues/14790#issuecomment-3675656025
My worry is still that we are modifying a core lib and weakening the safety
that it currently has. The window at the moment for going past the max queue
size is
```
if queue not too big
// Other threads check and see the queue is not to big and also add
add to queue
```
So we miss anything added between that check and the local thread's queue add
The new behavior in https://github.com/apache/iceberg/pull/11895/files
```
if queueSizeTracker not too large
// Other threads check and see the queueSizeTracker is not to big and
also add
add to queue
// Other threads check and see the queueSizeTracker is not to big and
also add
increment size tracker
```
Which means we miss elements added between the state check, the add and the
increment
I think if folks are ok with that gap increasing we can modify the code
though but this probably needs a broader audience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
