kevinjqliu commented on code in PR #2842:
URL: https://github.com/apache/iceberg-python/pull/2842#discussion_r2635779350
##########
pyiceberg/catalog/rest/__init__.py:
##########
@@ -269,6 +272,14 @@ def _create_session(self) -> Session:
return session
+ def is_scan_planning_enabled(self) -> bool:
+ """Check if server-side scan planning is enabled.
+
+ Returns:
+ True if enabled, False otherwise.
+ """
+ return property_as_bool(self.properties, REST_SCAN_PLANNING_ENABLED,
False)
Review Comment:
```suggestion
def is_rest_scan_planning_enabled(self) -> bool:
"""Check if server-side scan planning is enabled.
Returns:
True if enabled, False otherwise.
"""
return property_as_bool(self.properties, REST_SCAN_PLANNING_ENABLED,
REST_SCAN_PLANNING_ENABLED_DEFAULT)
```
nit: let's use "rest scan planning", maybe add
`REST_SCAN_PLANNING_ENABLED_DEFAULT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
