liurenjie1024 commented on code in PR #1943:
URL: https://github.com/apache/iceberg-rust/pull/1943#discussion_r2633425673
##########
crates/sqllogictest/src/schedule.rs:
##########
@@ -18,14 +18,26 @@
use std::collections::HashMap;
use std::fs::read_to_string;
use std::path::{Path, PathBuf};
+use std::sync::Arc;
use anyhow::{Context, anyhow};
+use iceberg::Catalog;
use serde::{Deserialize, Serialize};
use toml::{Table as TomlTable, Value};
use tracing::info;
use crate::engine::{EngineRunner, load_engine_runner};
+/// Configuration for a catalog in the schedule file.
+#[derive(Debug, Clone, Serialize, Deserialize)]
+pub struct CatalogConfig {
Review Comment:
Catalog config should be engine specific, e.g., it should be part of an
engine, rather in a common section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
