alessandro-nori commented on code in PR #14886:
URL: https://github.com/apache/iceberg/pull/14886#discussion_r2638050126
##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -142,6 +142,11 @@ default DeleteOrphanFiles equalAuthorities(Map<String,
String> newEqualAuthoriti
interface Result {
/** Returns locations of orphan files. */
Iterable<String> orphanFileLocations();
+
+ /** Returns the total number of orphan files. */
+ default long orphanFilesCount() {
+ return 0;
Review Comment:
I set it to 0 to be consistent with other action results. For example for
[rewriteDataFiles](https://github.com/apache/iceberg/blob/d6d44a7803b218e7da6d514e96ad98282f22a2b6/api/src/main/java/org/apache/iceberg/actions/RewriteDataFiles.java#L250)
the defaults are also set to 0.
I'm also fine with changing it to -1, let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
