zeroshade commented on code in PR #652:
URL: https://github.com/apache/iceberg-go/pull/652#discussion_r2641293463


##########
catalog/rest/rest.go:
##########
@@ -604,6 +604,10 @@ func (r *Catalog) createSession(ctx context.Context, opts 
*options) (*http.Clien
        session.defaultHeaders.Set("User-Agent", "GoIceberg/"+iceberg.Version())
        session.defaultHeaders.Set("X-Iceberg-Access-Delegation", 
"vended-credentials")
 
+       for k, v := range opts.headers {
+               session.defaultHeaders.Set(k, v)
+       }

Review Comment:
   This should probably happen earlier, otherwise these headers wouldn't get 
included in the call to `fetchAccessToken`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to