geruh commented on code in PR #14923:
URL: https://github.com/apache/iceberg/pull/14923#discussion_r2644200626
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -654,6 +654,22 @@ protected List<ManifestFile> writeDataManifests(
return writeManifests(files, group -> writeDataFileGroup(group, dataSeq,
spec));
}
+ // Deletes uncommitted manifests; clears list if clearManifests and any
deleted.
+ protected void deleteUncommitted(
+ List<ManifestFile> manifests, Set<ManifestFile> committed, boolean
clearManifests) {
+ boolean anyDeleted = false;
Review Comment:
While we are here, I believe the
[cleanUncommitted](https://github.com/apache/iceberg/blob/f25e07db6318184272d5c98dede4d268ee5288ab/core/src/main/java/org/apache/iceberg/BaseRewriteManifests.java#L347)
is basically doing the same thing, with a different signature. It may be worth
handling this case too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
