kevinjqliu commented on code in PR #2742:
URL: https://github.com/apache/iceberg-python/pull/2742#discussion_r2648676218
##########
Makefile:
##########
@@ -59,7 +59,7 @@ help: ## Display this help message
##@ Setup
install-uv: ## Ensure uv is installed
- @if ! command -v uv &> /dev/null; then \
+ @if ! command -v uv 2> /dev/null; then \
Review Comment:
```suggestion
@if ! command -v uv > /dev/null 2>&1; then \
```
`&>` is bash-specific syntax. `> /dev/null 2>&1` is POSIX-compliant and
works across all shells, ensuring the Makefile is portable to systems where
`/bin/sh` isn't bash (like Ubuntu's dash).
Same behavior, better compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
