kevinjqliu commented on code in PR #14928:
URL: https://github.com/apache/iceberg/pull/14928#discussion_r2651618833
##########
site/docs/spark-quickstart.md:
##########
@@ -46,13 +46,14 @@ services:
iceberg_net:
depends_on:
- rest
- - minio
+ - rustfs
volumes:
- ./warehouse:/home/iceberg/warehouse
- ./notebooks:/home/iceberg/notebooks/notebooks
+ - ./spark-defaults.conf:/opt/spark/conf/spark-defaults.conf
environment:
- - AWS_ACCESS_KEY_ID=admin
- - AWS_SECRET_ACCESS_KEY=password
+ - AWS_ACCESS_KEY_ID=rustfsadmin
+ - AWS_SECRET_ACCESS_KEY=rustfsadmin
Review Comment:
```suggestion
- AWS_ACCESS_KEY_ID=admin
- AWS_SECRET_ACCESS_KEY=password
```
nit: can we keep this the same as before? i think its a good idea to do the
smallest amount of change to the infra code. And if a change must be made, have
it isolated to only the storage infra (minio/rustfs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
