ragnard commented on PR #2866: URL: https://github.com/apache/iceberg-python/pull/2866#issuecomment-3697330087
> Looks like the java implementation has not deprecated the top-level `snapshot_id`. lets proceed with this change since it improves the current validation logic. > > Thanks for the PR! Lets add a test and it should be good to go! @kevinjqliu Thanks for the (quick!) review. I've changed the fix a bit: 1) Since the model is frozen it is not possible to use direct assignment, but it is also not possible to use `model_copy` like I did because an "after" validator needs to return the same model instance. I've reverted to a "before" validator, but handle the `dict` case properly. 2) For testing, the issue is not really about tables with statistics, but that it was not possible to instantiate the `SetStatisticsUpdate` model from a dict. I added an `model_roundtrips` helper that is now used to check that any model roundtrips (`model -> dict -> model`) correctly. Please let me know if you want further changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
