kevinjqliu commented on code in PR #2848:
URL: https://github.com/apache/iceberg-python/pull/2848#discussion_r2651644729
##########
tests/catalog/test_rest.py:
##########
@@ -2019,12 +2031,22 @@ def test_rest_scan_planning_enabled_by_property(self,
rest_mock: Mocker) -> None
assert catalog.is_rest_scan_planning_enabled() is True
- def test_rest_scan_planning_explicitly_disabled(self, rest_mock: Mocker)
-> None:
- rest_mock.get(
+ def test_rest_scan_planning_disabled_when_endpoint_unsupported(self,
requests_mock: Mocker) -> None:
+ requests_mock.get(
f"{TEST_URI}v1/config",
json={"defaults": {}, "overrides": {}},
status_code=200,
)
Review Comment:
```suggestion
// config endpoint does not populate endpoints
requests_mock.get(
f"{TEST_URI}v1/config",
json={"defaults": {}, "overrides": {}},
status_code=200,
)
```
nit: for clarity, add a comment here to be explicit that endpoints is missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
