aokolnychyi commented on a change in pull request #1738:
URL: https://github.com/apache/iceberg/pull/1738#discussion_r521693467



##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -134,4 +134,10 @@ private TableProperties() {
 
   public static final String ENGINE_HIVE_ENABLED = "engine.hive.enabled";
   public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+
+  public static final String WRITE_ISOLATION_LEVEL = "write.isolation-level";

Review comment:
       I think having only `write.merge.isolation` may not be descriptive 
enough since users won't know that we treat delete as a simplified version of 
merge.
   
   I would keep `write.row-level.isolation` with `write.row-level.mode` or 
introduce a pair of configs for each operation type like 
`write.delete.isolation` and `write.delete.mode`. I am ok with both options.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to