WZhuo commented on code in PR #457:
URL: https://github.com/apache/iceberg-cpp/pull/457#discussion_r2652841777
##########
src/iceberg/CMakeLists.txt:
##########
@@ -103,26 +104,30 @@ set(ICEBERG_SHARED_INSTALL_INTERFACE_LIBS)
list(APPEND
ICEBERG_STATIC_BUILD_INTERFACE_LIBS
+ cpr::cpr
Review Comment:
```
Result<std::string> LocationProvider::NewDataLocation(const PartitionSpec&
spec,
const PartitionValues&
partition_data,
const std::string& filename) =
0;
```
In LocationProvider::NewDataLocation, we must do url encoding for partition
names and partition values.
If not import `cpr` to iceberg core, maybe we need implement Url
encode/decode by ourselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
