wgtmac commented on PR #465: URL: https://github.com/apache/iceberg-cpp/pull/465#issuecomment-3701316305
> `if (!field.has_value() || !field.value().has_value())`, the first is for `Result`, the second is for `optional`. I agree it should propagate any errors from FindFieldByName(). Agreed. I think they are different errors and should be handled differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
