openinx commented on PR #14443: URL: https://github.com/apache/iceberg/pull/14443#issuecomment-3706841764
Hi @zhaoyunjiong, I will suggest to solve this problem in an more abstraction approach, as we discussed before. > We have multiple different components that will need to use iceberg-aliyun. It's possible to pass a custom Credentials Provider, but it will be very difficult and time-consuming to change multiple different projects to support that. Since the `OSSClientBuilder` support the abstracted `CredentialsProvider` interface, which means any user actually can custom their own `CredentialsProvider` implementation. And the auto-refresh `OIDCRoleArnCredentialProvider` is one of the `CredentialsProvider` implementation, and people may have some other kind of the implementations. The key point is: we may don't have the enough resources to support all kinds of the `CredentialsProvider` implementations in the offical apache iceberg repo, and we also shouldn't maintain all of them because the offical repo incline to maintain the common and general abstraction, so that peple can leverage the flexibility to custom their own. From another aspect, if users want to drive their own services which depends on this, they won't be blocked by the offical reviewing and merging process. That's why I highly suggest we introduce the abstraction to support the general customized `CredentialsProvider`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
