eickler commented on code in PR #1977:
URL: https://github.com/apache/iceberg-rust/pull/1977#discussion_r2658874011
##########
crates/integrations/datafusion/tests/integration_datafusion_test.rs:
##########
@@ -943,3 +943,64 @@ async fn test_insert_into_partitioned() -> Result<()> {
Ok(())
}
+
+#[tokio::test]
+async fn test_child_namespace_crud() -> Result<()> {
Review Comment:
Cool, I haven't heard about that one. I changed it, please let me know which
one you like better.
Side comment: I see the benefits of sqllogictest, but while writing the
test, I was wondering how far sqllogictest gets you in interoperability testing
SQL/Datafusion and Iceberg. In interoperability tests, you often verify fine
points on each side against each other, which would not be visible through a
test framework for one side only. As a result, you split tests between what you
can do in the framework and what you can't do (see the PR). There may be a case
for both "classic" and sqllogictest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
