CTTY commented on code in PR #1979:
URL: https://github.com/apache/iceberg-rust/pull/1979#discussion_r2659271467
##########
crates/iceberg/src/spec/manifest/writer.rs:
##########
@@ -437,7 +437,9 @@ impl ManifestWriter {
"format-version".to_string(),
(self.metadata.format_version as u8).to_string(),
)?;
- if self.metadata.format_version == FormatVersion::V2 {
+ if self.metadata.format_version == FormatVersion::V2
+ || self.metadata.format_version == FormatVersion::V3
+ {
Review Comment:
Good point! Updated the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]