plusplusjiajia commented on code in PR #482: URL: https://github.com/apache/iceberg-cpp/pull/482#discussion_r2659433714
########## src/iceberg/catalog/rest/rest_catalog.cc: ########## @@ -117,7 +117,7 @@ Result<std::shared_ptr<RestCatalog>> RestCatalog::Make( ICEBERG_ASSIGN_OR_RAISE(auto server_config, FetchServerConfig(*paths, config)); std::unique_ptr<RestCatalogProperties> final_config = RestCatalogProperties::FromMap( - MergeConfigs(server_config.overrides, config.configs(), server_config.defaults)); + MergeConfigs(server_config.defaults, config.configs(), server_config.overrides)); Review Comment: > Thanks for fixing this! Let's not complicate the PR. I think this change can be added without the test. Yes, i create a new pull request for it.https://github.com/apache/iceberg-cpp/pull/483/files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
