RussellSpitzer commented on code in PR #14593:
URL: https://github.com/apache/iceberg/pull/14593#discussion_r2662585763
##########
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java:
##########
@@ -490,6 +506,34 @@ private boolean containsNaNsOnly(Integer id) {
&& nanCounts.get(id).equals(valueCounts.get(id));
}
+ /**
+ * Returns the column's single value if all rows contain the same value,
no nulls, no NaNs, and
+ * lower bound equals upper bound. Returns null otherwise.
Review Comment:
Trying to think through if this is an issue with truncation, but I think our
logic there forcibly would shift the min and max value so that they wouldn't be
equal so I think this is safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
