emkornfield commented on code in PR #1851:
URL: https://github.com/apache/iceberg-rust/pull/1851#discussion_r2662723344
##########
crates/iceberg/src/spec/table_properties.rs:
##########
@@ -175,12 +195,38 @@ impl TryFrom<&HashMap<String, String>> for
TableProperties {
TableProperties::PROPERTY_WRITE_TARGET_FILE_SIZE_BYTES,
TableProperties::PROPERTY_WRITE_TARGET_FILE_SIZE_BYTES_DEFAULT,
)?,
+ avro_compression_codec: {
+ // Parse codec name and level from properties
+ let codec_name = parse_property(
+ props,
+ TableProperties::PROPERTY_AVRO_COMPRESSION_CODEC,
+
TableProperties::PROPERTY_AVRO_COMPRESSION_CODEC_DEFAULT.to_string(),
+ )?;
+
+ // Parse optional compression level (sentinel value 255 means
not specified)
+ let level_raw = parse_property(
+ props,
+ TableProperties::PROPERTY_AVRO_COMPRESSION_LEVEL,
+ 255u8,
Review Comment:
maybe make a constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
