wgtmac commented on code in PR #484:
URL: https://github.com/apache/iceberg-cpp/pull/484#discussion_r2663973104
##########
src/iceberg/catalog/rest/http_client.h:
##########
@@ -25,6 +25,7 @@
#include <string>
#include <unordered_map>
+#include "iceberg/catalog/rest/endpoint.h"
Review Comment:
```suggestion
```
##########
src/iceberg/catalog/rest/http_client.cc:
##########
@@ -135,7 +135,8 @@ Status HandleFailureResponse(const cpr::Response& response,
} // namespace
void HttpClient::PrepareSession(
- const std::string& path, const std::unordered_map<std::string,
std::string>& params,
+ const std::string& path, const HttpMethod& method,
Review Comment:
```suggestion
const std::string& path, HttpMethod method,
```
##########
src/iceberg/catalog/rest/http_client.h:
##########
@@ -109,7 +110,7 @@ class ICEBERG_REST_EXPORT HttpClient {
const ErrorHandler& error_handler);
private:
- void PrepareSession(const std::string& path,
+ void PrepareSession(const std::string& path, const HttpMethod& method,
Review Comment:
```suggestion
void PrepareSession(const std::string& path, HttpMethod method,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
