nastra commented on code in PR #14921:
URL: https://github.com/apache/iceberg/pull/14921#discussion_r2668045001
##########
core/src/main/java/org/apache/iceberg/FileCleanupStrategy.java:
##########
@@ -124,7 +134,92 @@ protected void deleteFiles(Set<String> pathsToDelete,
String fileType) {
.suppressFailureWhenFinished()
.onFailure(
(file, thrown) -> LOG.warn("Delete failed for {} file: {}",
fileType, file, thrown))
- .run(deleteFuncToUse::accept);
+ .run(
+ file -> {
+ deleteFuncToUse.accept(file);
+ summary.deletedFile(fileType);
+ });
+ }
+ }
+
+ static class DeleteSummary {
+ private final AtomicLong dataFilesCount = new AtomicLong(0L);
Review Comment:
don't we already have all of this in the `SnapshotSummary` when the snapshot
is committed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
