dramaticlly commented on code in PR #14964: URL: https://github.com/apache/iceberg/pull/14964#discussion_r2669646586
########## spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: ########## @@ -96,6 +96,7 @@ public class RewriteDataFilesSparkAction private boolean removeDanglingDeletes; private boolean useStartingSequenceNumber; private boolean caseSensitive; + private String branch = null; Review Comment: same as what Prashant suggested above, I think we can probably default branch to main and can always assert on `table.snapshot(branch) != null` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
