zhjwpku commented on code in PR #408:
URL: https://github.com/apache/iceberg-cpp/pull/408#discussion_r2670653252
##########
src/iceberg/snapshot.h:
##########
@@ -119,6 +120,67 @@ struct ICEBERG_EXPORT SnapshotRef {
return lhs.Equals(rhs);
}
+ /// \brief Builder class for constructing SnapshotRef objects
+ class ICEBERG_EXPORT Builder : public ErrorCollector {
Review Comment:
Agreed. Introduce MakeBranch and MakeTag, and remove the builder pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
