liurenjie1024 commented on code in PR #2006:
URL: https://github.com/apache/iceberg-rust/pull/2006#discussion_r2674560073


##########
crates/integrations/datafusion/src/physical_plan/scan.rs:
##########
@@ -51,6 +51,8 @@ pub struct IcebergTableScan {
     projection: Option<Vec<String>>,
     /// Filters to apply to the table scan
     predicates: Option<Predicate>,
+    /// Optional limit on the number of rows to return
+    pub(crate) limit: Option<usize>,

Review Comment:
   We should follow other fields to make field private and use function to 
expose it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to