nastra commented on code in PR #14734:
URL: https://github.com/apache/iceberg/pull/14734#discussion_r2675750547
##########
core/src/main/java/org/apache/iceberg/SchemaUpdate.java:
##########
@@ -164,7 +165,7 @@ private void internalAddColumn(
int newId = assignNewColumnId();
// update tracking for moves
- addedNameToId.put(fullName, newId);
+ addedNameToId.put(caseSensitivityAwareName(fullName), newId);
Review Comment:
initially I was thinking that we should not store the name in a case
insensitive way but only keep the lookup case insensitive (similar to how we do
it when we lookup fields in `Schema`. However, `Schema` keeps two maps, one
which is case sensitive and the other which is case insensitive. I was also
thinking whether this distinction would make sense for `SchemaUpdate` but
couldn't find a good enough argument to justify this, so I think the changes
you have here make sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
