amogh-jahagirdar commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2677917489
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -269,7 +277,6 @@ private void addInternal(DeleteFile file) {
DeleteFileSet deleteFiles =
newDeleteFilesBySpec.computeIfAbsent(spec.specId(), ignored ->
DeleteFileSet.create());
if (deleteFiles.add(file)) {
- addedFilesSummary.addedFile(spec, file);
hasNewDeleteFiles = true;
if (ContentFileUtil.isDV(file)) {
newDVRefs.add(file.referencedDataFile());
Review Comment:
Probably keep a boolean in-case we detect a duplicate. That way we don't
have to pay the price of grouping by referenced file everytime to detect
possible duplicates; only if we detect it at the time of adding it, we can do
the dedupe/merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
