pratik0316 commented on code in PR #2011:
URL: https://github.com/apache/iceberg-rust/pull/2011#discussion_r2679944905
##########
crates/iceberg/src/spec/table_metadata_builder.rs:
##########
@@ -875,6 +878,46 @@ impl TableMetadataBuilder {
Ok(self)
}
+ /// Reuse partition field IDs for equivalent fields from existing
partition specs.
+ ///
+ /// According to the Iceberg spec, partition field IDs must be reused if
an existing
+ /// partition spec contains an equivalent field (same source_id and
transform).
+ fn reuse_partition_field_ids(
+ &self,
+ unbound_spec: UnboundPartitionSpec,
+ ) -> Result<UnboundPartitionSpec> {
+ use std::collections::HashMap;
Review Comment:
nit: can we import at the top, just as convention in other parts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
