amogh-jahagirdar commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2680768882
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRemoveDanglingDeleteAction.java:
##########
@@ -370,7 +370,6 @@ public void testPartitionedDeletesWithEqSeqNo() {
// Add Data Files with EQ and POS deletes
DeleteFile fileADeletes = fileADeletes();
DeleteFile fileA2Deletes = fileA2Deletes();
- DeleteFile fileBDeletes = fileBDeletes();
Review Comment:
This test had to be fixed after the recent changes because the file paths
for data file B and B2 were set to the same before, so the DVs for both
referenced the same file (but that probably wasn't the intention of these
tests) so it was a duplicate. After this change we'd merge the DVs in the
commit, and then it'd actually get treated as a dangling delete and fail some
of the assertions.
Since these tests are just testing the eq. delete case we could just
simplify it by removing the usage of fileB deletes, it's a more minimal test
that tests the same thing.
Also note, generally I'd take this in a separate PR but I think there's a
good argument that this change should be in a 1.10.2 patch release to prevent
invalid table states; in that case we'd need to keep these changes together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
