wgtmac commented on code in PR #501:
URL: https://github.com/apache/iceberg-cpp/pull/501#discussion_r2680887641


##########
src/iceberg/util/transform_util.cc:
##########
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include "iceberg/util/transform_util.h"
+
+#include <array>
+#include <chrono>
+
+namespace iceberg {
+
+namespace {
+constexpr auto kEpochDate = std::chrono::year{1970} / std::chrono::January / 1;
+constexpr int64_t kMicrosPerMillis = 1'000;
+constexpr int64_t kMicrosPerSecond = 1'000'000;
+}  // namespace
+
+std::string TransformUtil::HumanYear(int32_t year_ordinal) {
+  auto y = kEpochDate + std::chrono::years{year_ordinal};
+  return std::format("{:%Y}", y);
+}
+
+std::string TransformUtil::HumanMonth(int32_t month_ordinal) {
+  auto ym = kEpochDate + std::chrono::months(month_ordinal);
+  return std::format("{:%Y-%m}", ym);
+}
+
+std::string TransformUtil::HumanDay(int32_t day_ordinal) {
+  auto ymd = std::chrono::sys_days(kEpochDate) + 
std::chrono::days{day_ordinal};
+  return std::format("{:%F}", ymd);
+}
+
+std::string TransformUtil::HumanHour(int32_t hour_ordinal) {
+  auto tp = std::chrono::time_point<std::chrono::system_clock, 
std::chrono::hours>{
+      std::chrono::hours{hour_ordinal}};
+  return std::format("{:%F-%H}", tp);
+}
+
+std::string TransformUtil::HumanTime(int64_t micros_from_midnight) {
+  std::chrono::hh_mm_ss<std::chrono::seconds> hms{
+      std::chrono::seconds{micros_from_midnight / kMicrosPerSecond}};
+  auto micros = micros_from_midnight % kMicrosPerSecond;
+  if (micros == 0 && hms.seconds().count() == 0) {
+    return std::format("{:%R}", hms);
+  } else if (micros == 0) {
+    return std::format("{:%T}", hms);
+  } else if (micros % kMicrosPerMillis == 0) {
+    return std::format("{:%T}.{:03d}", hms, micros / kMicrosPerMillis);
+  } else {
+    return std::format("{:%T}.{:06d}", hms, micros);
+  }
+}
+
+std::string TransformUtil::HumanTimestamp(int64_t timestamp_micros) {
+  auto tp = std::chrono::time_point<std::chrono::system_clock, 
std::chrono::seconds>{
+      std::chrono::seconds(timestamp_micros / kMicrosPerSecond)};
+  auto micros = timestamp_micros % kMicrosPerSecond;
+  if (micros == 0) {
+    return std::format("{:%FT%T}", tp);
+  } else if (micros % kMicrosPerMillis == 0) {
+    return std::format("{:%FT%T}.{:03d}", tp, micros / kMicrosPerMillis);
+  } else {
+    return std::format("{:%FT%T}.{:06d}", tp, micros);
+  }
+}
+
+std::string TransformUtil::HumanTimestampWithZone(int64_t timestamp_micros) {
+  auto tp = std::chrono::time_point<std::chrono::system_clock, 
std::chrono::seconds>{
+      std::chrono::seconds(timestamp_micros / kMicrosPerSecond)};
+  auto micros = timestamp_micros % kMicrosPerSecond;
+  if (micros == 0) {
+    return std::format("{:%FT%T}+00:00", tp);
+  } else if (micros % kMicrosPerMillis == 0) {
+    return std::format("{:%FT%T}.{:03d}+00:00", tp, micros / kMicrosPerMillis);
+  } else {
+    return std::format("{:%FT%T}.{:06d}+00:00", tp, micros);
+  }
+}
+
+std::string TransformUtil::Base64Encode(std::string_view str_to_encode) {
+  static constexpr std::string_view kBase64Chars =
+      "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
+  int32_t i = 0;
+  int32_t j = 0;
+  std::array<unsigned char, 3> char_array_3;

Review Comment:
   That may require extra cast when appending to the string.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to