Fokko commented on code in PR #2881:
URL: https://github.com/apache/iceberg-python/pull/2881#discussion_r2681790286
##########
pyiceberg/io/pyarrow.py:
##########
@@ -789,7 +789,7 @@ def visit_string(self, _: StringType) -> pa.DataType:
return pa.large_string()
def visit_uuid(self, _: UUIDType) -> pa.DataType:
- return pa.uuid()
+ return pa.binary(16)
Review Comment:
Ah, I see. I think that's reasonable.
Let's add a comment in the code, referring to
https://github.com/apache/iceberg-python/issues/2372 explaining why we we use
`binary(16)` rather than `uuid()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
