gaborkaszab commented on code in PR #14989:
URL: https://github.com/apache/iceberg/pull/14989#discussion_r2681953836
##########
core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java:
##########
@@ -351,7 +344,7 @@ private static Collection<PartitionStats>
computeAndMergeStatsIncremental(
Pair.of(key.first(), partitionDataToRecord((PartitionData)
key.second())),
value,
(existingEntry, newEntry) -> {
- existingEntry.appendStats(newEntry);
+ ((BasePartitionStatistics)
existingEntry).appendStats(newEntry);
Review Comment:
Refactored the code to move the `liveEntry()`, `appendStats()` etc.
functions into `PartitionStatsHandler` and populate the stats there using the
setter inherited from `StructLike`. This eliminated the need for the casts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
