Fokko commented on code in PR #2864:
URL: https://github.com/apache/iceberg-python/pull/2864#discussion_r2682192523
##########
pyiceberg/table/__init__.py:
##########
@@ -1970,12 +2051,35 @@ def scan_plan_helper(self) ->
Iterator[list[ManifestEntry]]:
],
)
- def plan_files(self) -> Iterable[FileScanTask]:
- """Plans the relevant files by filtering on the PartitionSpecs.
+ def _should_use_rest_planning(self) -> bool:
+ """Check if REST scan planning should be used for this scan."""
+ from pyiceberg.catalog.rest import RestCatalog
+
+ if not isinstance(self.catalog, RestCatalog):
+ return False
+ return self.catalog.is_rest_scan_planning_enabled()
+
+ def _plan_files_rest(self) -> Iterable[FileScanTask]:
Review Comment:
nit, To keep the same language:
```suggestion
def _plan_files_server_side(self) -> Iterable[FileScanTask]:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
