gaborkaszab commented on code in PR #13810:
URL: https://github.com/apache/iceberg/pull/13810#discussion_r2685564488
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -980,6 +980,32 @@ paths:
schema:
type: string
enum: [ all, refs ]
+ - in: query
+ name: referenced-by
+ description:
+ A comma-separated list of fully qualified view names (namespace
and view name) representing the view
+ reference chain when a table is loaded via a view. The list should
be ordered with the outermost view
+ first, followed by any intermediate views it references, down to
the view that directly references the table.
+ For a simple case where a view directly references the table, the
list contains a single view identifier.
+ For nested views (a view referencing another view which references
the table), the list contains multiple
+ view identifiers representing the complete dependency chain.
+
+ Each view identifier has the format namespace.viewName where
multipart namespace parts must be separated
+ by the namespace separator as indicated via the /config override
namespace-separator, which defaults to
Review Comment:
nit: the default is defined at some other part of the spec, so if it changes
for some reason this comment would be obsolete. I'm not sure it makes sense to
mention the default and all the other details here, just reference the part of
the spec that describes this. Other thing is that whenever we use
namespace-separator elsewhere, we don't want to have all this descriptions,
just at the definition side.
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -980,6 +980,32 @@ paths:
schema:
type: string
enum: [ all, refs ]
+ - in: query
+ name: referenced-by
+ description:
+ A comma-separated list of fully qualified view names (namespace
and view name) representing the view
Review Comment:
Probably this has been discussed so asking for my information: this param is
a comma-separated string now. Have you considered introducing it as an array of
TableIdentifiers or String?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
