wgtmac commented on code in PR #503:
URL: https://github.com/apache/iceberg-cpp/pull/503#discussion_r2686923871
##########
src/iceberg/expression/binder.cc:
##########
@@ -92,11 +92,13 @@ Result<bool> IsBoundVisitor::AlwaysFalse() { return true; }
Result<bool> IsBoundVisitor::Not(bool child_result) { return child_result; }
Result<bool> IsBoundVisitor::And(bool left_result, bool right_result) {
- return left_result && right_result;
+ ICEBERG_PRECHECK(left_result == right_result, "Found partially bound
expression");
Review Comment:
That is expected. `IsBoundVisitor` checks if all expressions are bound and
returns false if any is unbound. This is used to check if the expression has
called bind function along the tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
