danielcweeks commented on PR #14965: URL: https://github.com/apache/iceberg/pull/14965#issuecomment-3747136540
@oguzhanunlu I'm a little concerned around the semantics for a `404` on the config endpoint. The config endpoint doesn't specifically identify a warehouse, it the configuration endpoint for a REST Catalog server, so a 404 could also indicate that the url is incorrectly defined and the config endpoint is not available at the requested path. This could result in confusing errors if we aren't handling that correctly. You should add some tests that return a 404 that is not formatted as an error response and ensure that we're surfacing an appropriate error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
