rdblue commented on a change in pull request #1767:
URL: https://github.com/apache/iceberg/pull/1767#discussion_r523280550
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/BaseS3File.java
##########
@@ -29,10 +31,18 @@
private final S3Client client;
private final S3URI uri;
private HeadObjectResponse metadata;
+ private Map<String, String> properties;
BaseS3File(S3Client client, S3URI uri) {
this.client = client;
this.uri = uri;
+ this.properties = Collections.emptyMap();
Review comment:
I like the idea of getting rid of the map as soon as it is used. That
way we don't have to serialize it to tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
