erkanonl commented on PR #14872: URL: https://github.com/apache/iceberg/pull/14872#issuecomment-3749238959
> Thanks for the context ! I agree with the goal, we should be able to be aware of any failures that happen in this service without searching through the logs. This would help distinguish commit conflicts from other actionable failures so clients can classify failures and investigate. > > I don’t think returning a potentially unbounded `List<Exception>` is the right API for that. It creates memory/perf risk and still doesn’t eliminate the need to check logs for details. > > Can we switch this to an optional failure summary instead? For instance, return a bounded list of actionable failure summaries omitting retried exceptions, and each summary would be minimal context about the failure. > > I'll also let others chime in to hear their thoughts. I understand the concern around memory and performance. In some edge cases, there could be excessive number of exceptions. That is why, similar to your error summary suggestion, I'm limiting the exceptions into the size of 100. This should address the concerns I believe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
