gaborkaszab commented on code in PR #14398:
URL: https://github.com/apache/iceberg/pull/14398#discussion_r2694551066
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -96,6 +96,10 @@ public void initialize(String name, Map<String, String>
props) {
sessionCatalog.initialize(name, props);
}
+ protected RESTSessionCatalog sessionCatalog() {
Review Comment:
Originally this was package private with `@VisibleForTesting`. Dan suggested
to make this protected, that doesn't compile together with `@VisibleForTesting`
so I had to remove the annotation too.
I don't mind which way we go if we have consensus. I personally preferred
the original way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
