RussellSpitzer commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2695131742
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -269,10 +279,12 @@ private void addInternal(DeleteFile file) {
DeleteFileSet deleteFiles =
newDeleteFilesBySpec.computeIfAbsent(spec.specId(), ignored ->
DeleteFileSet.create());
if (deleteFiles.add(file)) {
- addedFilesSummary.addedFile(spec, file);
hasNewDeleteFiles = true;
if (ContentFileUtil.isDV(file)) {
- newDVRefs.add(file.referencedDataFile());
+ DeleteFileSet deletesForReferencedFile =
+ dvsByReferencedFile.computeIfAbsent(
+ file.referencedDataFile(), newFile -> DeleteFileSet.create());
Review Comment:
Don't we need to pass new file into the DeleteFileSet?
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -269,10 +279,12 @@ private void addInternal(DeleteFile file) {
DeleteFileSet deleteFiles =
newDeleteFilesBySpec.computeIfAbsent(spec.specId(), ignored ->
DeleteFileSet.create());
if (deleteFiles.add(file)) {
- addedFilesSummary.addedFile(spec, file);
hasNewDeleteFiles = true;
if (ContentFileUtil.isDV(file)) {
- newDVRefs.add(file.referencedDataFile());
+ DeleteFileSet deletesForReferencedFile =
+ dvsByReferencedFile.computeIfAbsent(
+ file.referencedDataFile(), newFile -> DeleteFileSet.create());
Review Comment:
Don't we need to pass newFile into the DeleteFileSet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
