danielcweeks commented on PR #15045: URL: https://github.com/apache/iceberg/pull/15045#issuecomment-3756618460
> Should we explicitly state that config and storage-credentials are excluded from the ETag? The current description implies this by only referencing "table metadata", but it might be worth adding a brief note to make it clear. I think we run the risk of over specifying, by trying to enforce everything that a server considers. Practically, I think this falls out of what the server wants the client to consider for cached reuse. This is also aligned with the HTTP `304` expectations where the server is the decision make for whether a previous response can be reused. For example, it's entirely reasonable that the server might want to track the credential timeout and expire the response if a request is getting to close to that expiration. In that case, the server would be considering it and may include when constructing the ETag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
