nastra commented on code in PR #15006:
URL: https://github.com/apache/iceberg/pull/15006#discussion_r2698461363
##########
core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java:
##########
@@ -87,7 +88,23 @@ private OutputFileFactory(
}
public static Builder builderFor(Table table, int partitionId, long taskId) {
- return new Builder(table, partitionId, taskId);
+ String formatAsString =
+ table.properties().getOrDefault(DEFAULT_FILE_FORMAT,
DEFAULT_FILE_FORMAT_DEFAULT);
+ PartitionSpec spec = table.spec();
Review Comment:
nit: both variables here can probably be just inlined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]