manuzhang commented on code in PR #14964:
URL: https://github.com/apache/iceberg/pull/14964#discussion_r2698668660
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -157,13 +159,24 @@ public RewriteDataFilesSparkAction filter(Expression
expression) {
return this;
}
+ public RewriteDataFilesSparkAction toBranch(String targetBranch) {
+ Preconditions.checkArgument(targetBranch != null, "Invalid branch name:
null");
Review Comment:
Can we have a branch with name "null"? The error message looks like
`targetBranch.equals("null")` to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
