xanderbailey commented on code in PR #2042:
URL: https://github.com/apache/iceberg-rust/pull/2042#discussion_r2701671007
##########
crates/iceberg/src/arrow/reader.rs:
##########
@@ -447,17 +449,70 @@ impl ArrowReader {
file_io: FileIO,
should_load_page_index: bool,
arrow_reader_options: Option<ArrowReaderOptions>,
+ key_metadata: Option<&[u8]>,
) -> Result<ParquetRecordBatchStreamBuilder<ArrowFileReader<impl FileRead
+ Sized>>> {
// Get the metadata for the Parquet file we need to read and build
// a reader for the data within
let parquet_file = file_io.new_input(data_file_path)?;
let (parquet_metadata, parquet_reader) =
try_join!(parquet_file.metadata(), parquet_file.reader())?;
+
let parquet_file_reader = ArrowFileReader::new(parquet_metadata,
parquet_reader)
.with_preload_column_index(true)
.with_preload_offset_index(true)
.with_preload_page_index(should_load_page_index);
+ // Check if file is encrypted but encryption feature is not enabled
+ #[cfg(not(feature = "encryption"))]
Review Comment:
Not sure if we want this or not...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
