pvary commented on code in PR #14729:
URL: https://github.com/apache/iceberg/pull/14729#discussion_r2704037393
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/CompareSchemasVisitor.java:
##########
@@ -43,23 +44,22 @@ public class CompareSchemasVisitor
extends SchemaWithPartnerVisitor<Integer, CompareSchemasVisitor.Result> {
private final Schema tableSchema;
+ private final boolean caseSensitive;
private final boolean dropUnusedColumns;
- private CompareSchemasVisitor(Schema tableSchema, boolean dropUnusedColumns)
{
+ private CompareSchemasVisitor(
+ Schema tableSchema, boolean caseSensitive, boolean dropUnusedColumns) {
this.tableSchema = tableSchema;
+ this.caseSensitive = caseSensitive;
this.dropUnusedColumns = dropUnusedColumns;
}
- public static Result visit(Schema dataSchema, Schema tableSchema) {
- return visit(dataSchema, tableSchema, true, false);
- }
Review Comment:
We can't remove this ATM, as this is public. We need to deprecate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
