jackye1995 commented on a change in pull request #1754:
URL: https://github.com/apache/iceberg/pull/1754#discussion_r524439227
##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3OutputFile.java
##########
@@ -29,7 +30,11 @@
public class S3OutputFile extends BaseS3File implements OutputFile {
public S3OutputFile(S3Client client, S3URI uri) {
- super(client, uri);
+ this(client, uri, AwsCatalogProperties.S3_SSE_TYPE_NONE, null, null);
+ }
+
+ public S3OutputFile(S3Client client, S3URI uri, String sseType, String
sseKey, String sseMd5) {
Review comment:
Yes I agree it sounds better to have all configuration in the separated
class. Let me update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
